Skip to content

Update Circle CI paths #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Update Circle CI paths #10

merged 1 commit into from
Jul 10, 2018

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented May 3, 2018

We changed the paths when introducing Circle testing on Python 2.

This will break some old links, but I feel it is still useful. Sometimes the browser script doesn't behave for me, and this is easier to advise users to use...

Ping @lesteve, @albertcthomas

We changed the paths when introducing Circle testing on Python 2.
@lesteve
Copy link
Member

lesteve commented May 3, 2018

I am fine with this, but in the longer term I'd rather have only one way of doing it. I agree this is not a huge problem though.

Sometimes the browser script doesn't behave for me

If you have steps to reproduce, maybe it is worth investigating. What I found is that sometimes the button either does not appear or clicking on it does not do anything. My experience is that refreshing the PR page always fixes it.

and this is easier to advise users to use...

There are some manual steps detailed in the doc for accessing the doc. I guess this could be improved (e.g. with screenshots)

@albertcthomas
Copy link

As far as I'm concerned, the manual steps described in the dev docs are very clear. I will try the browser script.

@lesteve lesteve merged commit cdbcfe5 into master Jul 10, 2018
@lesteve
Copy link
Member

lesteve commented Jul 10, 2018

Not sure why it was not merged before but I merged this. The scikit-learn.org/circle?<circleci-build-number> should be less broken that before.

Personally I would be in favour of getting rid of scikit-learn.org/circle?<circleci-build-number> in the long term but for now since this is in the doc so we may as well try to keep it working as much as we can.

@adrinjalali adrinjalali deleted the new-circle branch September 28, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants